Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi line field comments in SQL export. #206

Merged
merged 1 commit into from
Aug 4, 2024
Merged

Fix multi line field comments in SQL export. #206

merged 1 commit into from
Aug 4, 2024

Conversation

nktfh100
Copy link
Contributor

@nktfh100 nktfh100 commented Aug 3, 2024

Currently field comments with multiple lines are exported like this:

CREATE TABLE "User" (
	"id" INTEGER NOT NULL UNIQUE,
	-- line1
line2
line3
	"name" VARCHAR,
	PRIMARY KEY("id")
);

This PR fixes it so that multiple-line comments export correctly:

CREATE TABLE "User" (
	"id" INTEGER NOT NULL UNIQUE,
	-- line1
	-- line2
	-- line3
	"name" VARCHAR,
	PRIMARY KEY("id")
);

@vercel Vercel
Copy link

vercel bot commented Aug 3, 2024

@nktfh100 is attempting to deploy a commit to the dottle's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Aug 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drawdb ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 4, 2024 9:27am

1ilit
1ilit approved these changes Aug 4, 2024
View reviewed changes
Copy link
Member

@1ilit 1ilit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@1ilit 1ilit merged commit 318ed9a into drawdb-io:main Aug 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ALEXIS007891076 ALEXIS007891076 ALEXIS007891076 approved these changes

@1ilit 1ilit 1ilit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nktfh100 @1ilit @ALEXIS007891076